Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted support for SEP-0023. #319

Merged
merged 8 commits into from
May 23, 2020
Merged

Reverted support for SEP-0023. #319

merged 8 commits into from
May 23, 2020

Conversation

overcat
Copy link
Member

@overcat overcat commented May 23, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented May 23, 2020 •
edited
Loading

Codecov Report

Merging #319 into dev will decrease coverage by 0.01%.
The diff coverage is 99.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #319      +/-   ##
==========================================
- Coverage   98.95%   98.94%   -0.02%     
==========================================
  Files         117      115       -2     
  Lines        5558     5096     -462     
==========================================
- Hits         5500     5042     -458     
+ Misses         58       54       -4
Flag Coverage Δ
#unittests 98.94% <99.09%> (-0.02%) ⬇️
Impacted Files Coverage Δ
stellar_sdk/__init__.py 100.00% <ø> (ø)
stellar_sdk/exceptions.py 90.16% <ø> (-0.16%) ⬇️
stellar_sdk/operation/allow_trust.py 100.00% <ø> (ø)
stellar_sdk/operation/change_trust.py 100.00% <ø> (ø)
stellar_sdk/operation/create_account.py 100.00% <ø> (ø)
stellar_sdk/operation/create_passive_sell_offer.py 100.00% <ø> (ø)
stellar_sdk/operation/manage_buy_offer.py 100.00% <ø> (ø)
stellar_sdk/operation/manage_data.py 100.00% <ø> (ø)
stellar_sdk/operation/manage_sell_offer.py 100.00% <ø> (ø)
stellar_sdk/operation/path_payment.py 100.00% <ø> (ø)
... and 27 more

@overcat overcat marked this pull request as ready for review May 23, 2020 09:30
@overcat overcat merged commit e52f056 into dev May 23, 2020
overcat added a commit that referenced this pull request May 23, 2020
@overcat
refactor: revert support for SEP-0023. (#319)
8756b40 
* refactor: revert support for SEP-0023.

* code format

* code clean

* We will drop the memo id of MuxedAccounts and use G-strkeys when parse XDR

* fix
@overcat overcat deleted the dev-revert-sep23 branch June 18, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overcat